search

hellozedan / node-xmpp-bosh

Automatically exported from code.google.com/p/node-xmpp-bosh
0 stars 0 forks source link

Timeout crash #16

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Hi, got this since you added the HTTP timeout feature, after a HTTP timeouts:

/usr/local/lib/bosh/src/bosh.js:659
        res.socket.setTimeout(state.wait * 1000 + 10);
                   ^
TypeError: Cannot call method 'setTimeout' of undefined
    at add_held_http_connection (/usr/local/lib/bosh/src/bosh.js:659:20)
    at new_state_object (/usr/local/lib/bosh/src/bosh.js:424:3)
    at session_create (/usr/local/lib/bosh/src/bosh.js:467:15)
    at process_bosh_request (/usr/local/lib/bosh/src/bosh.js:1315:13)
    at bosh_requst_handler (/usr/local/lib/bosh/src/bosh.js:1692:3)
    at handle_get_bosh_request (/usr/local/lib/bosh/src/bosh.js:1732:4)
    at Object.emit (/usr/local/lib/node/.libs/eventpipe/eventpipe.js:63:25)
    at Server.http_request_handler (/usr/local/lib/bosh/src/bosh.js:1834:10)
    at Server.emit (events.js:67:17)
    at HTTPParser.onIncoming (http.js:1109:12)

Thanks to fix it ;)

Original issue reported on code.google.com by vanaryon on 20 Jun 2011 at 7:26

GoogleCodeExporter commented 8 years ago 
Does this happen consistently, or just once in a while? If only once in a 
while, do you have any debug logs around the time when it crashes? (will help 
nail the exact case)

Original comment by dhruvb...@gmail.com on 20 Jun 2011 at 9:36

GoogleCodeExporter commented 8 years ago 
I've hacked in a temporary fix (commit #365) which will prevent the crash but 
will log when it does happen. Please send me the error logs if any data shows 
up in them.

Original comment by dhruvb...@gmail.com on 20 Jun 2011 at 9:48

GoogleCodeExporter commented 8 years ago

Original comment by dhruvb...@gmail.com on 20 Jun 2011 at 9:49

GoogleCodeExporter commented 8 years ago 
I've pushed commit #366 which _should_ fix this issue. Closing for now. Plz. 
reopen if still not fixed.

Original comment by dhruvb...@gmail.com on 20 Jun 2011 at 10:11

GoogleCodeExporter commented 8 years ago 
Seems it's okay with your patch, thanks a lot!

Original comment by vanaryon on 20 Jun 2011 at 10:52

GoogleCodeExporter commented 8 years ago 
Welcome! Thanks for the bug report! Bumped up version to 0.3.2

Original comment by dhruvb...@gmail.com on 20 Jun 2011 at 10:58