search

hellsan631 / loopback-connector-aerospike

Connect Loopback to an Aerospike database - WIP
MIT License
6 stars 2 forks source link

Project Progress Thread #1

Open mattapperson opened 9 years ago

mattapperson commented 9 years ago

I would be happy to help!

hellsan631 commented 9 years ago

I put this up as a future todo, when I could find the time to develop it. I should have some time at the beginning of this weekend to sit down and put up most of the structure. Once that's down, i'd be glad to have some help developing/testing the connector.

mattapperson commented 9 years ago

Sounds good, just let me know when your ready :)

mattapperson commented 9 years ago

Also, I tried shooting you an email via your website to see if you were still freelancing FT, and your contact form returns a 403 error :)

hellsan631 commented 9 years ago

Ah thanks. I actually got the email, and sent a reply. Things have been a bit weird since i've added the google pagespeed module for apache, thanks for reporting the issue.

mattapperson commented 9 years ago

Great work so far! :)

hellsan631 commented 9 years ago

Thanks, but I was hoping to have more done so far. Trying to wrap my head around the way aerospike retrieves records to write some tests before writing methods atm.

mattapperson commented 9 years ago

So far I am making some OK progress... but it seems clear to me that we will need to inject some UDFs to get full usability. Is this something you are OK with?

hellsan631 commented 9 years ago

Could you give an example of an instance where a UDF is needed? Are you finding you will need them when it comes to applying filters? If I remember correctly, the couchbase connector had a few that dealt with its queries.

mattapperson commented 9 years ago

In particular things like delete all and queries that can do more then value equals or between

hellsan631 commented 9 years ago

I'm ok with it

mattapperson commented 9 years ago

I might recommend using bithound.io for code quality checks

mattapperson commented 9 years ago

With my latest PR we now have 50 tests passing and 49 tests failing... but at least we are over the hump!

hellsan631 commented 9 years ago

Ah, ok. Never used bithound, thanks. Added that. I usually use code climate because they also do test coverage, which i'd like to add at some point.

Sounds good! thanks for the great work.