search

helluvamatt / BootstrapIcons.Net

Bootstrap icons for WPF
MIT License
7 stars 3 forks source link

Other framework support #1

Open TrabacchinLuigi opened 2 years ago

TrabacchinLuigi commented 2 years ago

.NET 4.8 would be a nice addition for those who can't still upgrade easily

helluvamatt commented 2 years ago

Agreed, definitely for the WPF package.

I'm not sure about the AspNetCore package. It references Microsoft.AspNetCore.Razor.Runtime. Can you run the ASP.NET Core infrastructure on .NET Framework 4.*?

TrabacchinLuigi commented 2 years ago

Kinda, as long as you reference packages in the 3.x version, i could definitely help on that, but in a few days. I haven't yet looked at how the project is structured, but I feel like suggesting to tackle one issue at a time, let's start with WPF

helluvamatt commented 2 years ago

@TrabacchinLuigi Can you test this "pre-release" version: https://www.nuget.org/packages/BootstrapIcons.Wpf/1.8.1-rc1

TrabacchinLuigi commented 2 years ago

Sure, i'll be back with feedback soon

TrabacchinLuigi commented 2 years ago

Got some time, tried it, works great, no additional dlls are drawn into the project, the only thing that worries me a little is the fact it targets framework 4.5 and maybe can have some side effects. on the other hand targeting multiple frameworks could grow the package size considerably... so i guess till no problems shows up it's ok to target just that