Fix tox/testing matrix - Githubissues

hellysmile / django-activeurl

Easy-to-use active URL highlighting for Django

http://django-activeurl.readthedocs.io/en/latest/

Apache License 2.0

158 stars 29 forks source link

Fix tox/testing matrix #23

Closed tony closed 7 years ago

tony commented 7 years ago

@hellysmile next thing, let's get CI greenlighting

What do you want to have happen re: old django, 1.7 and less. Keep or let them go?

There is an issue with htmlparse in some of the test suites. Using a newer django version fixes it. Something happened in django 1.4.2
There's issues with the testbed and django url routes (patterns() deprecated in 1.8), that's fixed via newer django versions too

hellysmile commented 7 years ago

Can we just make next realease with support of Django versions which is officially supported right now?

tony commented 7 years ago

Which could be 1.8+, and python 2.7+

Yep.

hellysmile commented 7 years ago

Can You push AUTHORS and add all https://github.com/hellysmile/django-activeurl/graphs/contributors this guys?

hellysmile commented 7 years ago

According to https://www.djangoproject.com/download/ we need to leave 1.8, 1.10 and 1.11 As well it will be great to start testing 2.0, maybe just django master branch?

tony commented 7 years ago

Good point, we can opt out of 1.9.

And yeah nothing wrong with adding travis/tox tests to master.

hellysmile commented 7 years ago

We can drop frosted linter as well, this lib is dead.

Another great step forward can be replace nose by pytest

Right now here is copy of test matrix from tox to travis, which can be omitted - here is an example how we do it https://github.com/wikibusiness/aioelasticsearch

tony commented 7 years ago

Fine with me (re: tox -> travis)

Here is what django-extensions does: tox.ini .travis.yml

Also, love pytest.

tony commented 7 years ago

Fixed #29