Open jdolitsky opened 5 years ago
/assign
I wonder if such a change would actually cause the code to be harder to maintain? With the use of our Sh.py package, it is often straightforward to use kubectl. Such as:
Should pass kubectl get nodes
Sh.Run kubectl get pods --namespace=default
@jdolitsky do you still see this issue as a valuable improvement?
@marckhouzam I think for commands which require counting number of results etc. this would simply alot
For example this function: https://github.com/helm/acceptance-testing/blob/master/lib/Kubectl.py#L17
Agreed
Instead of shelling out to kubectl, should just import and use the Python library: https://github.com/kubernetes-client/python