helm / chart-releaser-action

A GitHub Action to turn a GitHub project into a self-hosted Helm chart repo, using helm/chart-releaser CLI tool
https://github.com/helm/chart-releaser
Apache License 2.0
559 stars 206 forks source link

Remove deprecated charts-repo-url option #123

Closed jftanner closed 1 year ago

jftanner commented 2 years ago

The --charts-repo option is no longer used, since https://github.com/helm/chart-releaser/pull/144. This PR removes it from the action as well.

Fixes #122.

jftanner commented 1 year ago

Thanks for the review @davidkarlsen! Anything else you need from me to merge it?

joshuasimon-taulia commented 1 year ago

charts_repo_url is still referenced in the repo documentation. the common use case for this action is to to run cr in a workflow on merge to main branch and upload a chart to a separate github repo. what's the best way to accomplish this now that charts_repo_url has been removed? i see these cli options in the latest (v1.5.0) release of chart-releaser, but they don't seem to be settable by env vars via this action

  -r, --git-repo string                GitHub repository
  -u, --git-upload-url string          GitHub Upload URL (only needed for private GitHub) (default "https://uploads.github.com/")
  -o, --owner string                   GitHub username or organization

creating a cr.yaml file is not practical for reusable workflow users with large numbers of application repositories

krapie commented 1 year ago

As @joshuasimon-taulia mentioned, charts_repo_url is still referenced in latest commit. Because of this, I had to look for various Issues and PRs in chart-releaser and chart-releaser-action :(

I will update documentation to prevent further usage of charts_repo_url option.