helm / chart-releaser-action

A GitHub Action to turn a GitHub project into a self-hosted Helm chart repo, using helm/chart-releaser CLI tool
https://github.com/helm/chart-releaser
Apache License 2.0
543 stars 199 forks source link

Add `changed_charts` and `chart_version` outputs #130

Closed n-oden closed 1 year ago

n-oden commented 1 year ago

This should let downstream steps make conditional decisions based on what we found.

Also: fix a confusing double-negative test in main().

Signed-off-by: Nathan J. Mehl n@oden.io

n-oden commented 1 year ago

@cpanato ping? :)

n-oden commented 1 year ago

@davidkarlsen ping? :)

cpanato commented 1 year ago

I think this will require you to change the action.yml as well to make that explicitly the outputs

n-oden commented 1 year ago

@cpanato per the docs declaring outputs in action.yml is optional:

If you don't declare an output in your action metadata file, you can still set outputs and use them in a workflow.

That said if you'd prefer to have them explicitly declared I can definitely do that.

n-oden commented 1 year ago

@cpanato ping? :)

n-oden commented 1 year ago

@cpanato thanks for the review! I've implemented your changes.

n-oden commented 1 year ago

@cpanato ping? :)

afernandez-01 commented 1 year ago

+1

cpanato commented 1 year ago

@n-oden testing is failing because in the CI we only install and do not run the full action, so the changed_charts.txt and the other file does not exist, we might want to add a safe guard to avoid that error

n-oden commented 1 year ago

@cpanato fixed; try again?

n-oden commented 1 year ago

@cpanato ping? :)

n-oden commented 1 year ago

@davidkarlsen @cpanato hey folks, any chance we can get this merged?

cpanato commented 1 year ago

@n-oden i will test this again

n-oden commented 1 year ago

@cpanato all done, take another look?

calvinrzachman commented 11 months ago

This is a great addition! Any chance we could cut a new release containing these changes?