Closed n-oden closed 1 year ago
@cpanato ping? :)
@davidkarlsen ping? :)
I think this will require you to change the action.yml as well to make that explicitly the outputs
@cpanato per the docs declaring outputs in action.yml is optional:
If you don't declare an output in your action metadata file, you can still set outputs and use them in a workflow.
That said if you'd prefer to have them explicitly declared I can definitely do that.
@cpanato ping? :)
@cpanato thanks for the review! I've implemented your changes.
@cpanato ping? :)
+1
@n-oden testing is failing because in the CI we only install and do not run the full action, so the changed_charts.txt
and the other file does not exist, we might want to add a safe guard to avoid that error
@cpanato fixed; try again?
@cpanato ping? :)
@davidkarlsen @cpanato hey folks, any chance we can get this merged?
@n-oden i will test this again
@cpanato all done, take another look?
This is a great addition! Any chance we could cut a new release containing these changes?
This should let downstream steps make conditional decisions based on what we found.
Also: fix a confusing double-negative test in main().
Signed-off-by: Nathan J. Mehl n@oden.io