Remove deprecated `charts_repo_url` option in documentation

helm / chart-releaser-action

A GitHub Action to turn a GitHub project into a self-hosted Helm chart repo, using helm/chart-releaser CLI tool

https://github.com/helm/chart-releaser

Apache License 2.0

543 stars 199 forks source link

Closed krapie closed 1 year ago

krapie commented 1 year ago

As charts_repo_url option has been deprecated: https://github.com/helm/chart-releaser-action/pull/123, reference of charts_repo_url in REAMDE.md documentation should also be removed to prevent further usage.

Updates: 2023.04.18

mark_as_latest option also seems to be deprecated too. Removed mark_as_latest in doc and codes as well.

cpanato commented 1 year ago

@krapie there are some conflicts here

krapie commented 1 year ago

@cpanato resolved conflicts.

cpanato commented 1 year ago

why removing the mark_as_latest? that is not deprecated

krapie commented 1 year ago

I have made this PR few months ago, so I don't remember why I removed mark_as_latest. Perhaps I have misunderstood something or so...

I have rollbacked mark_as_latest related codes.

Also, it seems like https://github.com/helm/chart-releaser-action/pull/144 has already been merged few minutes ago, and seems to resolve this issue.

I think it will be better to remove mentions of charts_repo_url in Pre-requisites in README.md too.