search

helm / chart-releaser-action

A GitHub Action to turn a GitHub project into a self-hosted Helm chart repo, using helm/chart-releaser CLI tool
https://github.com/helm/chart-releaser
Apache License 2.0
543 stars 199 forks source link

Added: --packages-with-index parameter #148

Closed valeriano-manassero closed 10 months ago

valeriano-manassero commented 1 year ago

Added flag --package-with-index implemented in https://github.com/helm/chart-releaser/pull/304.

Implements #147

jasonmoore2k commented 11 months ago

I tested your revision and while the path in the index became relative, the chat file was published in the release rather than in the git repo alongside the index file.

immae1 commented 11 months ago

Hi @valeriano-manassero Any chance of you resolving the conflicts and completing the PR? Because @jasonmoore2k seems to be right, I've tested the action on my side - but unfortunately the tar file is not stored in my gh-pages branch. I've had a look at your code and in theory its fine, but you've missed two flags (--push and --index-path .) that need to be set regarding the CR binary docs: https://github.com/helm/chart-releaser#usage

adjustments on my side: if [[ -n "$packages_with_index" ]]; then args+=(--packages-with-index --push --skip-existing)

and: if [[ -n "$packages_with_index" ]]; then args+=(--packages-with-index --index-path .) fi

Best

valeriano-manassero commented 11 months ago

Thanks for suggestions; I hope I didn't messed up anything during rebase but it should be good now.

jasonmoore2k commented 11 months ago

packages_with_existing needs a default value at top of main()

Also, fails when packaging multiple charts in a single job with a “Updates were rejected because a pushed branch tip is behind its remote counterpart”

jasonmoore2k commented 11 months ago

Dug further and the multi-push issue should be fixed by this PR.

valeriano-manassero commented 10 months ago

@cpanato there is anything blocking this one? Don't want to put any pressure but I guess it useful to have this since chart-releaser is already capable of doing it. Thanks.

nicklausbrown commented 10 months ago

any idea when this will be available once merged? @valeriano-manassero thanks for the contributions and @jasonmoore2k thanks for the reviews! After merging into a github action on main for myself, I can confirm that this worked for my repo as well.