search

helm / chart-releaser

Hosting Helm Charts via GitHub Pages and Releases
Apache License 2.0
661 stars 107 forks source link

cr crashes as package version gets accidentially encoded #281

Open michas2 opened 1 year ago

michas2 commented 1 year ago

Packet versions follow semantic versioning, which allows adding build metadata to have versions like this: 3.11627+2e5eff15bf01

cr uses the name and the version to create files like this: cloudbees-core-3.11627+2e5eff15bf01.tgz

Then, in releaser.go it calls downloadURL.String() which will give the encoded representation like this: cloudbees-core-3.11627%2B2e5eff15bf01.tgz

Therefore the file will not be found and cr crashes.

Please stick with the unencoded filename there to avoid this.

mway-niels commented 6 months ago

We're running into the same problem.

Chart.yaml

version: "2.2.5+2"

https://github.com/relution-io/relution-kubernetes/commit/98b89d46ff96e4daa40f8732854b7f4bda0776c0