search

helm / chart-releaser

Hosting Helm Charts via GitHub Pages and Releases
Apache License 2.0
645 stars 108 forks source link

fix: allow package versions with extended semversioning #406

Open jlpedrosa opened 1 month ago

jlpedrosa commented 1 month ago

It is reported that chart-releaser fails when the version number has some separator: https://github.com/helm/chart-releaser-action/issues/56

When a tag has the + symbol ie: 2.0.0+Chart1, which is semver compliant see https://github.com/helm/chart-releaser-action/issues/56.

When githubs return the download URL for the chart, it contains escape character %2B, but the actual filename is +Chart1. This causes the log/trace linked in the issue above.

This PR adds the filenameParameter to the addToIndexFile function. So instead of receiving the URL only, it receives the url and the correct filename for the asset, that later parts of the code will try to open. Added test cases to validate this scenario.

Also this PR adds support for ssh url syntax for remotes, so it also can be executed locally.

kg-ops commented 1 month ago

Is there a plan to merge this PR to mainstream ?