USE URL from API when private

helm / chart-releaser

Hosting Helm Charts via GitHub Pages and Releases

Apache License 2.0

684 stars 113 forks source link

USE URL from API when private #428

Open mattclegg opened 5 months ago

mattclegg commented 5 months ago

@cpanato I'd like to support using the URL from the API instead of the BrowserDownloadURL as that appears to be the only one that supports personal access tokens on private repos.

ref

cpanato commented 4 months ago

What is the motivation for that? Sorry, I did not quite understand that.

Also what is the relation with the link you added with this PR?

mattclegg commented 4 months ago

I'm trying to use a chart that has been published to a private GitHub repository. The BrowserDownloadURL from GitHub API doesn't work with "personal access tokens" (which I need to access to the private repository).

The reference to the link is because I've also had to update the helm binary to send the correct headers when downloading the chart from a private GitHub repository.

So now I just need to update index.yaml to use; https://api.github.com/repos/$OWNER/$REPO/releases/assets/$ASSET_ID

KrisJohnstone commented 2 months ago

+1 :)