helm / chart-testing-action

A GitHub Action to lint and test Helm charts
https://github.com/helm/chart-testing
Apache License 2.0
251 stars 71 forks source link

The `changed` in step `list-changed` will always be true #112

Closed FushuWang closed 1 year ago

FushuWang commented 1 year ago

The output of ct list-changed will have other strings even if the chart is not changed.

          changed=$(ct list-changed --target-branch ${{ github.event.repository.default_branch }})
          if [[ -n "$changed" ]]; then
            echo "::set-output name=changed::true"
          fi
Linting charts...
>>> helm version --template {{ .Version }}
>>> git rev-parse --is-inside-work-tree
>>> git merge-base origin/main HEAD
>>> git diff --find-renames --name-only c8b9381a98059c07b5b65510b8162c5df3f43cd0 -- charts

And those strings will make the if check always true. So that's why we will meet errors like this issue.

cpanato commented 1 year ago

not able to reproduce the issue, see my comment https://github.com/helm/chart-testing-action/issues/102#issuecomment-1482596871

closing this as not reproduced