Support for library charts

hairmare commented 3 years ago

Is this a request for help?:

Probably

Is this a BUG REPORT or FEATURE REQUEST? (choose one):

This is a FEATURE REQUEST. I would like to be able to test library charts to some degree using the chart-testing automation.

This will help with maintaining library charts since it could make it easier to change them if they are properly tested.

Version of Helm and Kubernetes:

"latest"

What happened:

I created a library chart on a repo with the chart-testing GitHub Action enabled.

What you expected to happen:

That chart-testing does some sort or more or less meaningful tests on my library chart.

How to reproduce it (as minimally and precisely as possible):

Run the install tests of chart-testing against a charts/ folder containing a library chart.

Anything else we need to know:

I think there are a few reasonable ideas on how to tackle this but wanted to get some input:

this could be out of scope for chart-testing and I should ignore my library. If this is the way to go I should try to always combine any changes to the library chart with changes to an example chart that uses the library (this might result in some sorts of dependency-hell when it comes to managing Chart.lock files in PRs)
chart-testing could support a concrete example of the library in the ci/ folder and use that for testing
chart-testing could only support linting library charts and not exit with and simply not attempt to install a library chart (i can already do this by ignoring my library chart)

lukasz-mitka commented 3 years ago

I would go with not event trying to install library charts. Since it's not possible just skip them.

For anyone looking for a workaround: Create separate config file for install only which excludes library charts.

gionn commented 1 year ago

We have a library chart among other charts, it's quite surprising to see that libraries chart are not supported.

Before discovering this issue, I had also to create an empty values.yaml otherwise was even failing earlier.

Will try to use a separated config for ct install but looks really clunky.

github-actions[bot] commented 5 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

lukasz-mitka commented 5 months ago

bad bot. Still needed.

github-actions[bot] commented 4 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

hairmare commented 4 months ago

most likely ct should just skip library charts during ct install, but it should lint them during ct lint. I can do this now using two different configs, but keeping those up to date feels error prone and a lot of manual work.

would a change that just makes ct install skip library charts be a welcome change?

davidkarlsen commented 4 months ago

@hairmare I'd say that makes sense. Just skip them and print a warning.

cpanato commented 4 months ago

+1 with tests :)

github-actions[bot] commented 3 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

lukasz-mitka commented 3 months ago

bad bot. Still needed.

cpanato commented 3 months ago

bad bot.

Still needed.

Are willing to work on this and open a pr?

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

lukasz-mitka commented 1 month ago

Are willing to work on this and open a pr?

No, sorry, no time to spare.

github-actions[bot] commented 3 weeks ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

lukasz-mitka commented 3 weeks ago

bad bot

lukasz-mitka commented 3 weeks ago

@cpanato Could you set an exempt-issue-labels for these kind of issues?

cpanato commented 3 weeks ago

sounds good @lukasz-mitka

helm / chart-testing

Support for library charts #237