search

helm / chartmuseum

helm chart repository server
https://chartmuseum.com
Apache License 2.0
3.57k stars 400 forks source link

feat: allow user set forcePathStyle for s3 storage #731

Closed warjiang closed 11 months ago

warjiang commented 11 months ago

!!! Note: This PR depends on the merger of another PR to be merged. We have mentioned a PR in chartmuseum/storage to support users to manually set s3ForcePathStyle. After the pr of storage is merged, I will remove the WIP status of the current PR.

This PR mainly provides support for command line parameters, allowing users to set s3ForcePathStyle through command line parameters.

If possible, anyone can help me review the PR in chartmuseum/storage. thks

warjiang commented 11 months ago

somthing wrong with git(dco not works with ssh ), still make dco finally

scbizu commented 11 months ago

@warjiang Hi , we just release the storage v0.14.1 , can you fix your go.mod ?

warjiang commented 11 months ago

@warjiang Hi , we just release the storage v0.14.1 , can you fix your go.mod ?

@scbizu Already update the dependencies of the chartmuseum and resolve the WIP status. Also update usage of new options of amazon-storage in the README.md. BTW thank you very much for your quick response ⚡

scbizu commented 11 months ago

@cbuto PTAL

warjiang commented 11 months ago

can anyone help to merge this pr, i want to use official chartmuseum instead of self build, thks

scbizu commented 11 months ago

@warjiang try our canary image .