search

helm / charts

⚠️(OBSOLETE) Curated applications for Kubernetes
Apache License 2.0
15.5k stars 16.83k forks source link

[stable/sonarqube] Changing plugins doesn't restart the pods #13193

Closed tolleiv closed 5 years ago

tolleiv commented 5 years ago

Is this a request for help?: NO

Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT

Version of Helm and Kubernetes: v2.13.1 / 1.11

Which chart: stable/sonarqube

What happened: When changing the list of plugins for an already installed release, the pods will just continue running and never be recreated or pick up the new plugins automatically.

What you expected to happen: Pods should be restarted gracefully and pick up the new plugins during startup.

How to reproduce it (as minimally and precisely as possible):

helm upgrade my-sonarqube stable/sonarqube --install
... (wait + check that no plugins are installed) ...
cat > values.yaml <<EOF
plugins:
  install:
    - "https://github.com/AmadeusITGroup/sonar-stash/releases/download/1.3.0/sonar-stash-plugin-1.3.0.jar"
EOF
helm upgrade my-sonarqube stable/sonarqube --install  --values=values.yaml 
... (wait + check that still no plugins are installed) ...

Anything else we need to know:

I think that implementing a checksum annotation for the plugin list as suggested in the official Chart tips and tricks would solve it.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

stale[bot] commented 5 years ago

This issue is being automatically closed due to inactivity.

tolleiv commented 5 years ago

For everyone else looking into this - adding --recreate-pods to the helm command is a workaround of course.