helm / charts

⚠️(OBSOLETE) Curated applications for Kubernetes
Apache License 2.0
15.49k stars 16.82k forks source link

Uncommenting the features for extraVolumeMounts and extra Volumes result in a key not found #5320

Closed devdavidkarlsson closed 6 years ago

devdavidkarlsson commented 6 years ago

BUG REPORT

Version of Helm and Kubernetes: helm 2.6.1 minikube v0.25.1

Which chart: ingress-nginx

What happened:

When a customTemplate is enabled it appears, the yaml gets corrupt if extraVolumes or extraVolumeMounts are added as well.

  customTemplate:
    configMapName: "gw-template"
    configMapKey: "template"

Uncommenting the features for extraVolumeMounts and extraVolumes result in a key not found error. If I remove the custom template I can add extra volumes without getting the error.

The rows in question

  extraVolumeMounts: {}
  ## Additional volumeMounts to the controller main container.
   - name: copy-portal-skins
    mountPath: /var/lib/lemonldap-ng/portal/skins

  extraVolumes: {}
   # - name: copy-portal-skins
   #   emptyDir: {}

error converting YAML to JSON: yaml: line 212: did not find expected key

What you expected to happen:

Successful deployment was expected and/or successful --dry-run --debug

How to reproduce it (as minimally and precisely as possible):

Uncomment the rows under extraVolumes and extraVolumeMounts in the values.yaml in the ingress-nginx helm.

Anything else we need to know:

robinro commented 6 years ago

@devdavidkarlsson You need to remove the {}:

 extraVolumeMounts:
   - name: copy-portal-skins
     mountPath: /var/lib/lemonldap-ng/portal/skins
stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

stale[bot] commented 6 years ago

This issue is being automatically closed due to inactivity.