helm / charts

⚠️(OBSOLETE) Curated applications for Kubernetes
Apache License 2.0
15.5k stars 16.83k forks source link

Should we still add missing charts OWNERS files? #7446

Closed scottrigby closed 5 years ago

scottrigby commented 6 years ago

Issue to track PRs adding OWNERS files to charts still missing them.

Note I'm not sure if it's worth the extra 148 PRs now that we're working toward the charts distributed search proposal 🤔 Then again, perhaps any little bit towards distributed ownership could be a help in the PR deluge (these ones at least would be quick & easy to review/merge)? Adding this issue for discussion.

find incubator stable -mindepth 1 -maxdepth 1 -type d '!' -exec test -e "{}/OWNERS" ';' -print | sort -u:

cpanato commented 6 years ago

i can own some if needed.

scottrigby commented 6 years ago

@cpanato Awesome, thanks! Let's wait and discuss at the next meeting. I added it to the agenda. We have a large number of PRs now, so we should talk about this in context of the transition priorities.

cpanato commented 6 years ago

@scottrigby cool, I will try to join the next meeting. the problem it is in the same time as my planning weekly meeting :( but count me for any help

mattfarina commented 6 years ago

Before we make owners files we do need to make sure the people are trusted and have contributed. There are numerous people listed as owners who have not contributed before.

K8s has a trust system via sponsorships. How do we trust the people we add to owners files?

christian-roggia commented 6 years ago

Should this list exclude deprecated charts? incubator/drone has been moved to stable and it has its OWNERS file, the incubator chart is there only because of the deprecation process.

prydonius commented 6 years ago

I think this should exclude deprecated charts given we remove the maintainers, @scottrigby do you want to update the list to reflect that?

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

maver1ck commented 5 years ago

incubator/cassandra done :)

cpanato commented 5 years ago

@scottrigby @mattfarina what is the decision here? I'm still willing to take some

scottrigby commented 5 years ago

@cpanato The decision here was to add these OWNERS files only as needed (when people request to help maintain them), since our efforts would be better spent moving to the distributed charts hub than opening all of these PRs each with a chart bump (and the coordination with other PRs against those same charts also bumping the version).