search

helm / community

Helm community content
https://helm.sh
417 stars 175 forks source link

hip introducing `export-values` for better composability #242

Closed c0d1ngm0nk3y closed 1 year ago

c0d1ngm0nk3y commented 2 years ago

Composing Helm charts using dependencies is currently limited because it is not possible to create a chart with a defined set of values and distribute them to subcharts.

This hip proposes an export-values structure to address this issue.

c0d1ngm0nk3y commented 2 years ago

@hickeyma , @marckhouzam HI. Is there anything missing? It would be great to get some feedback for this HIP, but we cannot add reviewers. What is the preferred approach?

c0d1ngm0nk3y commented 2 years ago

Would really be great to get any reaction at all. Is the HIP still used at all?

joshuasimon-taulia commented 2 years ago

It's currently next to impossible to use the parent - subchart pattern with the helmfile values that jenkins-x passes to each release. This would unblock me in that scenario and also enable me to make a bunch of my other chart values way more DRY.

bridgetkromhout commented 2 years ago

Discussion in March 17, 2022 helm developer call: https://docs.google.com/document/d/1d-6xJEx0C78csIYSPKJzRPeWaHG_8W1Hjl72OJggwdc/edit?usp=sharing

marckhouzam commented 2 years ago

Looks like the next available number for a HIP is "0016". @c0d1ngm0nk3y you can replace the "9999" with "0016" in the file and in the name of the file.

phil9909 commented 2 years ago

Looks like the next available number for a HIP is "0016". @c0d1ngm0nk3y you can replace the "9999" with "0016" in the file and in the name of the file.

Done

loewenstein commented 2 years ago

@jdolitsky anything missing to get this HIP merged?

phil9909 commented 2 years ago

@jdolitsky anything missing to get this HIP merged?

HIPs need two approvals to get merged

loewenstein commented 2 years ago

With two approvals (from @scottrigby & @jdolitsky) and @mattfarina's comments supposedly addressed, could we maybe proceed and try to get this HIP merged soon and the implementation into 3.11.0?

3.11.0 is the next feature release and will be released on January 18, 2023