helm / community

Helm community content
https://helm.sh
417 stars 175 forks source link

HIP for git based dependencies #321

Open dominykas opened 10 months ago

dominykas commented 10 months ago

This is an attempt to revive #214, hopefully leading to a revival of https://github.com/helm/helm/pull/11258 down the road.

There are some things I don't know yet, but I hope these can be resolved during the review process here:

cc @no9 - you asked for it ;) thanks for your help!

dominykas commented 9 months ago

I'm also now thinking about sub-dependencies... Should there be any behaviors prescribed if a dependency is installed from a registry, but it contains a sub-dependency which was originally installed from git?

On npm git dependencies are a major security risk, but dependencies are vendored in Helm, so it's maybe not a concern?

There's also the case of git-based dependencies having sub-dependencies (some of which may also be from git?) - meaning that we probably need to do a recursive helm dep up inside the cloned folders? Which could also result in some infinite loops, if someone puts in a circular dependency that way? Does this need to be solved in the HIP? I'm starting to get worried about the scope a little bit - I wonder if it's possible to move forward with an MVP implementation behind a flag and get some broader feedback?