helm install should rollback on failure

helm / helm-classic

⚠️(OBSOLETE) Helm Classic v1

https://github.com/helm/helm

Other

574 stars 54 forks source link

helm install should rollback on failure #304

Open adamreese opened 8 years ago

adamreese commented 8 years ago

helm should cleanup any successful manifest uploads if one fails

mboersma commented 8 years ago

:+1: In testing the "deis" chart I ran into errors, and I expected to be able to helm install again, but I couldn't because some objects were still installed. helm uninstall <chart> && helm install <chart> works, but I did expect helm install essentially to be atomic.

technosophos commented 8 years ago

As we're starting to do the automatic dependency resolution work, I'm thinking that...

On failure, a chart should uninstall any of the components it already installed, but...
A chart should not uninstall any of the charts it depends upon, even if those were installed expressly to satisfy this chart's dependency requirements.

That will keep us from potentially harmful bugs where we remove charts that were actually being used.

Does that make sense?

mboersma commented 8 years ago

@technosophos that behavior makes sense for me when dependency resolution is in place, unless running helm install again would error on the dependent charts already being installed. But it sounds like dependency management would be smart enough not to.

arschles commented 8 years ago

:+1: also makes sense to me. tiny thing - it'd be helpful to log when helm install runs into already-installed dependencies.