helm / helm-www

The Helm website for docs, blog and project info.
https://helm.sh
MIT License
204 stars 514 forks source link

regexFindAll code example a bit silly #1660

Closed sparecycles closed 4 days ago

sparecycles commented 4 days ago

The code example for regexFindAll at https://helm.sh/docs/chart_template_guide/function_list/#regexfindall-mustregexfindall

reads:

regexFindAll "[2,4,6,8]" "123456789" -1

This is a bit misleading as [...] character classes are not comma-delimited, so the example matches any of the character class [2456,] (including any comma characters, which I'm sure is not intended here).

Best to delete the commas and not to propagate this anti-pattern to future generations. 😉