search

helm / hub

⚠️(OBSOLETE) Former distributed charts search for hub.helm.sh. Now see https://artifacthub.io/
https://artifacthub.io/
Apache License 2.0
251 stars 281 forks source link

Add CI to check for name length issues #362

Closed mattfarina closed 4 years ago

mattfarina commented 4 years ago

On more than one occassion a PR was submitted with a name that's too long. Error turn up like:

Error: failed to create resource: CronJob.batch "helm-hub-monocular-sync-scheduled-kubernetes-dashboard" is invalid: metadata.name: Invalid value: "helm-hub-monocular-sync-scheduled-kubernetes-dashboard": must be no more than 52 characters

Error: UPGRADE FAILED: failed to create resource: CronJob.batch "helm-hub-monocular-sync-scheduled-kubernetes-dashboard" is invalid: metadata.name: Invalid value: "helm-hub-monocular-sync-scheduled-kubernetes-dashboard": must be no more than 52 characters

We should have a CI check to catch these.

scottrigby commented 4 years ago

I was looking for a Monocular issue for this. There are a few, but this is the clearest I've found so far: https://github.com/helm/monocular/pull/621

mattfarina commented 4 years ago

No longer needed. Closing