helm / hub

⚠️(OBSOLETE) Former distributed charts search for hub.helm.sh. Now see https://artifacthub.io/
https://artifacthub.io/
Apache License 2.0
251 stars 281 forks source link

READMEs getting 404 on Helm Hub #369

Closed wallyqs closed 3 years ago

wallyqs commented 4 years ago

Right now in the nats helm charts on helm hub I'm getting a 404 on the readmes from the NATS charts:

https://hub.helm.sh/charts/nats/nats

I had fixed it already at some point but somehow broke again readme should be there: https://github.com/nats-io/k8s/tree/master/helm/charts/nats

and in the command line it works too:

$ helm show readme nats/nats | head -n 1
# NATS Server

Any pointers on what to look at to fix it?

https://github.com/nats-io/k8s/issues/64

Thanks!

mattfarina commented 4 years ago

@wallyqs This looks to be a bug. I can manually extract the archive and see the readme. The error logs are reporting...

gzip: invalid header"

What process are you using to create the archive file and on which os?

Additionally, the Artifact Hub is a place you can list nats. In your case I would create an organization and then add the chart repository to the organization. I wonder how it would display there.

wallyqs commented 4 years ago

Thanks @mattfarina this is the output of helm version on OSX:

version.BuildInfo{Version:"v3.2.3", GitCommit:"8f832046e258e2cb800894579b1b3b50c2d83492", GitTreeState:"clean", GoVersion:"go1.13.12"}

I generate the tarball by calling helm package as I think it is regularly done, like:

git clone https://github.com/nats-io/k8s/
cd k8s/helm/charts/
helm package nats

# Then when releasing
helm repo index .
billimek commented 4 years ago

I'm seeing the same behavior for all of the charts that I host on helm hub as well. I was about to ping you in slack @mattfarina but found this issue first.

In my case, the charts are being packaged with the helm chart-releaser-action via GitHub actions.

Picking one as an example, https://hub.helm.sh/charts/billimek/speedtest-prometheus, shows 404s from the helm hub API. The chart lives here and the associated index.yaml for that chart is,

  speedtest-prometheus:
  - apiVersion: v2
    appVersion: 1.1.0
    created: "2020-04-30T10:18:16.900108405Z"
    description: Prometheus Exporter for the official Speedtest CLI
    digest: 0b766b98a5eb53e85dda649879d94935903a3674b76a233c6803badc2b52e396
    home: https://github.com/billimek/billimek-charts/tree/master/charts/speedtest-prometheus
    icon: https://cdn.speedcheck.org/images/reviews/ookla-logo.png
    keywords:
    - speedtest
    - influxdb
    - grafana
    maintainers:
    - email: jeff@billimek.com
      name: billimek
    name: speedtest-prometheus
    sources:
    - https://github.com/billimek/prometheus-speedtest-exporter
    type: application
    urls:
    - https://github.com/billimek/billimek-charts/releases/download/speedtest-prometheus-1.0.1/speedtest-prometheus-1.0.1.tgz
    version: 1.0.1
  - apiVersion: v2
    appVersion: 1.1.0
    created: "2020-04-30T09:19:28.306385496Z"
    description: Prometheus Exporter for the official Speedtest CLI
    digest: 065f28dc1678de6f07e9cf528222eaba17d4986fa99bc7af44f5cc4c1226fd92
    home: https://github.com/billimek/billimek-charts/tree/master/charts/speedtest-prometheus
    icon: https://img.favpng.com/12/7/24/speedtest-net-logo-internet-access-png-favpng-yVPchiKuhWWAXA41Vpak0NUvx.jpg
    keywords:
    - speedtest
    - influxdb
    - grafana
    maintainers:
    - email: jeff@billimek.com
      name: billimek
    name: speedtest-prometheus
    sources:
    - https://github.com/billimek/prometheus-speedtest-exporter
    type: application
    urls:
    - https://github.com/billimek/billimek-charts/releases/download/speedtest-prometheus-1.0.0/speedtest-prometheus-1.0.0.tgz
    version: 1.0.0

And here is the raw output of the last action run to release that particular chart:

2020-04-30T10:18:13.7330884Z ##[group]Run helm/chart-releaser-action@v1.0.0-rc.2
2020-04-30T10:18:13.7331660Z with:
2020-04-30T10:18:13.7331860Z   charts_repo_url: https://billimek.com/billimek-charts/
2020-04-30T10:18:13.7332013Z   charts_dir: charts
2020-04-30T10:18:13.7332137Z env:
2020-04-30T10:18:13.7332709Z   CR_TOKEN: ***
2020-04-30T10:18:13.7332833Z ##[endgroup]
2020-04-30T10:18:13.7813664Z billimek-charts
2020-04-30T10:18:13.7832202Z Looking up latest tag...
2020-04-30T10:18:14.0109763Z Discovering changed charts since 'speedtest-prometheus-1.0.0'...
2020-04-30T10:18:14.0388000Z Installing chart-releaser...
2020-04-30T10:18:15.0065455Z Packaging chart 'charts/speedtest-prometheus'...
2020-04-30T10:18:15.0468408Z Successfully packaged chart and saved it to: .cr-release-packages/speedtest-prometheus-1.0.1.tgz
2020-04-30T10:18:15.0482235Z Releasing charts...
2020-04-30T10:18:16.2043462Z + cr index -o billimek -r billimek-charts -c https://billimek.com/billimek-charts/
2020-04-30T10:18:16.2043757Z Updating charts repo index...
2020-04-30T10:18:16.3799562Z ====> Using existing index at .cr-index/index.yaml
2020-04-30T10:18:16.8994976Z ====> Found speedtest-prometheus-1.0.1.tgz
2020-04-30T10:18:16.8996005Z ====> Extracting chart metadata from .cr-release-packages/speedtest-prometheus-1.0.1.tgz
2020-04-30T10:18:16.9001245Z ====> Calculating Hash for .cr-release-packages/speedtest-prometheus-1.0.1.tgz
2020-04-30T10:18:16.9001987Z --> Updating index .cr-index/index.yaml
2020-04-30T10:18:16.9189751Z ++ mktemp -d
2020-04-30T10:18:16.9200762Z + gh_pages_worktree=/tmp/tmp.7GLqKWiJ3g
2020-04-30T10:18:16.9201500Z + git worktree add /tmp/tmp.7GLqKWiJ3g gh-pages
2020-04-30T10:18:16.9215168Z Preparing worktree (new branch 'gh-pages')
2020-04-30T10:18:16.9239458Z Branch 'gh-pages' set up to track remote branch 'gh-pages' from 'origin'.
2020-04-30T10:18:16.9317655Z HEAD is now at 0c15a0e Update index.yaml
2020-04-30T10:18:16.9321862Z + cp --force .cr-index/index.yaml /tmp/tmp.7GLqKWiJ3g/index.yaml
2020-04-30T10:18:16.9337290Z + pushd /tmp/tmp.7GLqKWiJ3g
2020-04-30T10:18:16.9337651Z + git add index.yaml
2020-04-30T10:18:16.9373001Z + git commit '--message=Update index.yaml' --signoff
2020-04-30T10:18:16.9439244Z [gh-pages 3c3e808] Update index.yaml
2020-04-30T10:18:16.9439604Z  1 file changed, 21 insertions(+)
2020-04-30T10:18:16.9443654Z + local repo_url=***github.com/billimek/billimek-charts
2020-04-30T10:18:16.9444720Z + git push ***github.com/billimek/billimek-charts gh-pages
2020-04-30T10:18:19.9628292Z To https://github.com/billimek/billimek-charts
2020-04-30T10:18:19.9628860Z    0c15a0e..3c3e808  gh-pages -> gh-pages
2020-04-30T10:18:19.9729868Z + popd
2020-04-30T10:18:19.9730009Z + popd

image

I'm trying to compare other charts which seem to render properly with those that don't and haven't yet seen a pattern.

billimek commented 4 years ago

FWIW, the same chart appears to render properly in the new Artifact Hub: https://artifacthub.io/packages/chart/billimek-charts/speedtest-prometheus

wallyqs commented 4 years ago

Interesting, the Helm charts for NATS also seem ok in artifacthub: https://artifacthub.io/packages/helm/nats/nats

mattfarina commented 3 years ago

This is likely an issue that was in Helm that has been fixed. The helm version that was being used by the Helm Hub was older due to #212. We no longer have that issue as this is turned down so I am closing.