search

helm / kind-action

A GitHub Action for Kubernetes IN Docker - local clusters for testing Kubernetes
https://kind.sigs.k8s.io/
Apache License 2.0
306 stars 76 forks source link

Feature request: local registry #76

Open Siegfriedk opened 1 year ago

Siegfriedk commented 1 year ago

Hi,

we use helm/chart-testing and tried helm/kind-action but to do a proper test, i needed to push a temp image to the local kind registry.

To achieve this, i switched from helm/kind-action to container-tools/kind-action (https://github.com/container-tools/kind-action) which provides this functionality.

Would be great if you could support this too so we could have all of it from one trusted source.

Tx,

Sigi

tthvo commented 7 months ago

Hi, I am new here but I can help take a look if no one has yet worked on it :D

cpanato commented 7 months ago

@tthvo go for it

atrakic commented 2 weeks ago

Just a suggestion and of you need to keep CI more lightweight, consider using temp registry https://ttl.sh (I'm not affiliated)

tthvo commented 1 week ago

Just a suggestion and of you need to keep CI more lightweight, consider using temp registry https://ttl.sh (I'm not affiliated)

I think it's good alternative. Though, IMO, I think local registry would be preferable in most cases since it does not require pushing/pulling images over the network. Also, if images are meant to be private, it's not desirable for them to be available publicly :D

Siegfriedk commented 1 week ago

Just a suggestion and of you need to keep CI more lightweight, consider using temp registry https://ttl.sh (I'm not affiliated)

Our CI/CD Pipeline builds the image, then pushes it to the local registry and then tests it. An intermediate step through an external temp registry is not an reasonable alternative.

wjiec commented 1 day ago

My scenario just needs a compatibility test for PR, which only needs to be pushed to the local registry temporarily. Any further plans for this PR?