search

helmerapp / micro

top notch GIFs, right from your desktop
https://www.helmer.app/micro
Other
25 stars 5 forks source link

You can time your esc keypress into dismissing the crop window and bugging the app out #82

Closed amit-chaudhari1 closed 2 months ago

amit-chaudhari1 commented 2 months ago

Description

You can time your esc keypress into dismissing the crop window and bugging the app out and having the record button on. and end up on a state that you can see the record button but not have the crop area (the position capture is successful there but we've dismissed the window, removing the visual indication for the area that we're going to capture)

image

Reproducible steps

press CtrlorCmdShift2 and then press Esc at the right time. You have to press Esc at the right time. timing the frame creation after doing mouse_up at the end of the drag.

Possible Solution

we are hiding windows from the JS side we should be handling them from the rust side

clearlysid commented 2 months ago

Solved with #79 by moving Cropper/Record window hiding logic to the rust side.