feat: impl patch with alpha plugin flag.

helmfile / chartify

Convert K8s manifests/Kustomization into Helm Chart

Apache License 2.0

75 stars 29 forks source link

feat: impl patch with alpha plugin flag. #59

Closed Peefy closed 1 year ago

Peefy commented 1 year ago

Purpose

feat: impl patch with alpha plugin flag. More information is here: https://github.com/helmfile/helmfile/discussions/827

I found that the helmfile HelmState structure passed chartifyOpts.EnableKustomizeAlphaPlugins=true to chartify, but it did not take effect in chartify.

Tests

For transformer and alpha plugin, I have added a integration test using the AnnotationsTransformer kustomize plugin

integration_test.go

Peefy commented 1 year ago

Thank you @yxxhero PTAL.

yxxhero commented 1 year ago

@Peefy please fix the ci error. then I will merge this PR.

yxxhero commented 1 year ago

@Peefy please see https://github.com/helmfile/chartify/pull/59/files#diff-a996645aeb193b0b8cf4f2ba786a4b4fefabf9d09b71a5382fb17681950b6d9aL161

Peefy commented 1 year ago

@Peefy please fix the ci error. then I will merge this PR.

@yxxhero Sorry, I forgot to submit the want file and I've added it.

yxxhero commented 1 year ago

@Peefy please see https://github.com/helmfile/chartify/pull/59/files#diff-a996645aeb193b0b8cf4f2ba786a4b4fefabf9d09b71a5382fb17681950b6d9aL161

Peefy commented 1 year ago

@Peefy please see https://github.com/helmfile/chartify/pull/59/files#diff-a996645aeb193b0b8cf4f2ba786a4b4fefabf9d09b71a5382fb17681950b6d9aL161

fixed.