search

helmfile / chartify

Convert K8s manifests/Kustomization into Helm Chart
Apache License 2.0
75 stars 29 forks source link

feat: use helmBin() for kustomize build for helmChart in kustomization.yaml #64

Closed moririnson closed 9 months ago

moririnson commented 10 months ago

This adds support --helm-binary for helmChart in kustomization.yaml by:

Resolves https://github.com/helmfile/helmfile/issues/1121

yxxhero commented 10 months ago

@moririnson could you add some tests?

moririnson commented 10 months ago

@yxxhero I added tests. Please review 🙇

In the first commit, I added cases for --enable-alpha-plugins=true (current helmfile) and --enable-alpha-plugins=false . The --enable-alpha-plugins=false case is expected to fail.

In the next commit, as the title of the pull request suggests, I made it so that helmBin() is also carried over to kustomize build. Both test cases for --enable-alpha-plugins=true/false should succeed.

Interestingly, it seems that --enable-helm is enabled when --enable-alpha-plugins=true. I couldn't find any description to that effect, so I might be misunderstanding something.

moririnson commented 9 months ago

@yxxhero Should I submit a p-r to use chartify 0.17.0 on the helmfile side? Or should I wait for dependabot? I hope I can use this fixes in my work.Thank you.

yxxhero commented 9 months ago

@moririnson you can post a PR. thanks so much.

yxxhero commented 9 months ago

@moririnson you can post a PR. thanks so much.

I will merge it as soon as I can.

moririnson commented 9 months ago

@yxxhero I posted PR. Please merge when you can~ 🙏 https://github.com/helmfile/helmfile/pull/1140/files