search

helmfile / chartify

Convert K8s manifests/Kustomization into Helm Chart
Apache License 2.0
75 stars 29 forks source link

Replace deprecated patchesStrategicMerge with current patches #85

Closed gllb closed 4 months ago

gllb commented 4 months ago

This MR aim to fix https://github.com/helmfile/helmfile/issues/1237.

yxxhero commented 4 months ago

@gllb please fix DCO.

yxxhero commented 4 months ago

could you add some tests?

gllb commented 4 months ago

You mean to adapt existing one or create new one ? Because the existing test should cover this patch, or I miss something ?

yxxhero commented 4 months ago

@gllb ok. please fix DCO: https://github.com/helmfile/chartify/pull/85/checks?check_run_id=24558803618

yxxhero commented 4 months ago

In your local branch, run: git rebase HEAD~1 --signoff Force push your changes to overwrite the branch: git push --force-with-lease origin support_current_kustomize_patches

genofire commented 2 months ago

@gllb thank you for your work here :bouquet: