[Bug]: Support special versions of pytorch in setup.py

helmholtz-analytics / heat

Distributed tensors and Machine Learning framework with GPU and MPI acceleration in Python

https://heat.readthedocs.io/

MIT License

210 stars 53 forks source link

[Bug]: Support special versions of pytorch in setup.py #1030

Closed mtar closed 1 year ago

mtar commented 2 years ago

What happened?

Special versions of pytorch adds a plus sign and some text to the version number like 1.12.1+cpu or 1.12.1+cu116. When installing Heat, these packages get replaced (1.12.1).

https://github.com/helmholtz-analytics/heat/blob/5ff03147ae0ff338a07efaefaf3f288e7090c6cc/setup.py#L36

Version

main (development branch), release

PyTorch version

1.12.1

mtar commented 2 years ago

using less rather than less equal for the upper bound fixes the issue for me