search

helmholtz-analytics / heat

Distributed tensors and Machine Learning framework with GPU and MPI acceleration in Python
https://heat.readthedocs.io/
MIT License
209 stars 53 forks source link

Update implementation of `meshgrid` w.r.t. new PyTorch-meshgrid #1231

Open mrfh92 opened 11 months ago

mrfh92 commented 11 months ago

  1. When testing the current implementation of heat.meshgrid, PyTorch throws the following warning 

    UserWarning: torch.meshgrid: in an upcoming release, it will be required to pass the indexing argument.

    that indicates that some changes will be necessary in the future... (In the current implementation of Heats meshgrid, there is even a comment # pytorch does not support the indexing keyword: switch vectors and subsequent code that seems to be only due to the fact that at that time PyTorch didnt accept indexing arguments for its meshgrid...)

  2. Optional: our meshgrid only works if at most one of the input arrays is distributed... can we maybe provide a workaround? (e.g., leaving the largest input array splitted and making all others unsplit?)

samadpls commented 11 months ago

Hey @ mrfh92 , Can I work on this issue?

mrfh92 commented 11 months ago

@samadpls Sure 👍 Feel free to ask if there are any questions

github-actions[bot] commented 11 months ago

Branch bugs/1231-Update_implementation_of_meshgrid_w_r_t_new_PyTorch-meshgrid created!

github-actions[bot] commented 9 months ago

This issue is stale because it has been open for 60 days with no activity.