helmholtz-analytics / heat

Distributed tensors and Machine Learning framework with GPU and MPI acceleration in Python
https://heat.readthedocs.io/
MIT License
209 stars 53 forks source link

Support batch 1-d convolution in `ht.signal.convolve` #1515

Closed ClaudiaComito closed 2 months ago

ClaudiaComito commented 3 months ago

Due Diligence

Description

This PR expands ht.signal.convolve to perform 1-D convolutions on a batch of 1-D arrays, i.e.

Issue/s resolved: #1514 Related: #1396

Changes proposed:

Type of change

Memory requirements

Performance

Does this change modify the behaviour of other functions? If so, which?

yes, instead of returning ValueError when signal is n-D, ht.convolve now raises a ValueError only if batch convolution isn't possible (shapes mismatch, unsuitable distribution)

github-actions[bot] commented 3 months ago

Thank you for the PR!

github-actions[bot] commented 3 months ago

Thank you for the PR!

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.89%. Comparing base (064f495) to head (332ae51). Report is 239 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1515 +/- ## ========================================== + Coverage 91.85% 91.89% +0.03% ========================================== Files 80 80 Lines 11878 11916 +38 ========================================== + Hits 10911 10950 +39 + Misses 967 966 -1 ``` | [Flag](https://app.codecov.io/gh/helmholtz-analytics/heat/pull/1515/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=helmholtz-analytics) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/helmholtz-analytics/heat/pull/1515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=helmholtz-analytics) | `91.89% <100.00%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=helmholtz-analytics#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 months ago

Thank you for the PR!

github-actions[bot] commented 3 months ago

Thank you for the PR!

github-actions[bot] commented 2 months ago

Thank you for the PR!

ClaudiaComito commented 2 months ago

@JuanPedroGHM @krajsek @mrfh92 thanks for reviewing, I think I addressed all points, let me know if something's missing.