Closed Reisii closed 2 months ago
Thank you for the PR!
Attention: Patch coverage is 91.66667%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 92.06%. Comparing base (
9d3af11
) to head (956e3d0
). Report is 32 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
heat/core/io.py | 91.66% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
discussed in the PR talk: we will make pandas an optional dependency, as already the case for h5py etc.
Thank you for the PR!
Thank you for the PR!
Thank you for the PR!
Thank you for the PR!
Thank you for the PR!
Thank you for the PR!
@Reisii something failed on the CUDA-runner. Can you reproduce this on our workstation?
@Reisii something failed on the CUDA-runner. Can you reproduce this on our workstation?
So it works perfectly fine with the workstation, I'll just try to test out using ht.MPI_WORLD.Barrier() on different places
Thank you for the PR!
Thank you for the PR!
Thank you for the PR!
Thank you for the PR!
Thank you for the PR!
Thank you for the PR!
lines 1187/88, 1268/87 are not covered by tests so far. It looks like that there is no remainder in the devision (?) That lines 1203-1209 are not covered can't be resolved as this would require a different setup without h5py, which is currently out of scope
Thank you for the PR!
Thank you for the PR!
Thank you for the PR!
Thank you for the PR!
Due Diligence
Description
Adds the same feature of PR#1388 now for .csv-files. Loads multiple .csv-files at once and concatenates them along an axis given as an input by the user. A function can be passed on as a parameter. The function would edit the pandas.Dataframe in way that it can be converted into a NumPy-Array without any problems
Issue/s resolved: #1550
Changes proposed:
-
-
Type of change
Memory requirements
Performance
Does this change modify the behaviour of other functions? If so, which?
no