helmholtz-analytics / heat

Distributed tensors and Machine Learning framework with GPU and MPI acceleration in Python
https://heat.readthedocs.io/
MIT License
211 stars 54 forks source link

Features/1550 extension of load npy from path to csv-files with same functionality #1551

Closed Reisii closed 2 months ago

Reisii commented 4 months ago

Due Diligence

Description

Adds the same feature of PR#1388 now for .csv-files. Loads multiple .csv-files at once and concatenates them along an axis given as an input by the user. A function can be passed on as a parameter. The function would edit the pandas.Dataframe in way that it can be converted into a NumPy-Array without any problems

Issue/s resolved: #1550

Changes proposed:

-

-

Type of change

Memory requirements

Performance

Does this change modify the behaviour of other functions? If so, which?

no

github-actions[bot] commented 4 months ago

Thank you for the PR!

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.06%. Comparing base (9d3af11) to head (956e3d0). Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
heat/core/io.py 91.66% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1551 +/- ## ========================================== - Coverage 92.07% 92.06% -0.01% ========================================== Files 83 83 Lines 12144 12180 +36 ========================================== + Hits 11181 11214 +33 - Misses 963 966 +3 ``` | [Flag](https://app.codecov.io/gh/helmholtz-analytics/heat/pull/1551/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=helmholtz-analytics) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/helmholtz-analytics/heat/pull/1551/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=helmholtz-analytics) | `92.06% <91.66%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=helmholtz-analytics#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mrfh92 commented 4 months ago

discussed in the PR talk: we will make pandas an optional dependency, as already the case for h5py etc.

github-actions[bot] commented 4 months ago

Thank you for the PR!

github-actions[bot] commented 4 months ago

Thank you for the PR!

github-actions[bot] commented 4 months ago

Thank you for the PR!

github-actions[bot] commented 4 months ago

Thank you for the PR!

github-actions[bot] commented 4 months ago

Thank you for the PR!

github-actions[bot] commented 4 months ago

Thank you for the PR!

mrfh92 commented 4 months ago

@Reisii something failed on the CUDA-runner. Can you reproduce this on our workstation?

Reisii commented 4 months ago

@Reisii something failed on the CUDA-runner. Can you reproduce this on our workstation?

So it works perfectly fine with the workstation, I'll just try to test out using ht.MPI_WORLD.Barrier() on different places

github-actions[bot] commented 4 months ago

Thank you for the PR!

github-actions[bot] commented 4 months ago

Thank you for the PR!

github-actions[bot] commented 4 months ago

Thank you for the PR!

github-actions[bot] commented 4 months ago

Thank you for the PR!

github-actions[bot] commented 3 months ago

Thank you for the PR!

github-actions[bot] commented 3 months ago

Thank you for the PR!

mrfh92 commented 3 months ago

lines 1187/88, 1268/87 are not covered by tests so far. It looks like that there is no remainder in the devision (?) That lines 1203-1209 are not covered can't be resolved as this would require a different setup without h5py, which is currently out of scope

github-actions[bot] commented 3 months ago

Thank you for the PR!

github-actions[bot] commented 3 months ago

Thank you for the PR!

github-actions[bot] commented 2 months ago

Thank you for the PR!

github-actions[bot] commented 2 months ago

Thank you for the PR!