helmholtz-analytics / heat

Distributed tensors and Machine Learning framework with GPU and MPI acceleration in Python
https://heat.readthedocs.io/
MIT License
210 stars 53 forks source link

indexing vectors with index arrays #824

Open mtar opened 3 years ago

mtar commented 3 years ago

Description A clear and concise description of the bug and the associated functionality.

various bugs when using index arrays for indexing on distributed one-dimensional DNDarrays.

To Reproduce Steps to reproduce the behavior:

  1. Which module/class/function is affected? getitem
  2. What are the circumstances under which the bug appears? array indexing on distributed 1d arrays
  3. What is the exact error message / erroneous behavior? Runtime error / Segmentation fault

Expected behavior A clear and concise description of what you expected to happen. Return DNDarray with indexed values.

Illustrative If applicable, add screenshots or minimal examples to help explain your problem.

x = ht.arange(10,1,-1, split=0)
# wrong order on procs > 2
x[ht.array([3, 3, 1, 8])]

# Segmentation fault procs > 1
x[ht.array([3,3,-3,8])]

# Runtime error procs > 1
x[ht.array([[1,1],[2,3]])]

Version Info master f7f6c35

Additional comments Any other comments here. First case related to #703

Not tested yet:

github-actions[bot] commented 1 year ago

Branch bugs/824-indexing_vectors_with_index_arrays created!

ClaudiaComito commented 1 year ago

Still open, addressed in #938


reviewed within #1109