helmus / Jira-Hot-Linker

Jira Hot Linker
MIT License
39 stars 14 forks source link

Dark mode #26

Open e271828- opened 1 year ago

e271828- commented 1 year ago

Please add dark mode support!

Both GitHub and Jira have it, so this makes the white popup jarring.

aareman commented 9 months ago

@e271828- I opened a PR #27 which adds dark mode based on browser preference.

aareman commented 9 months ago

@helmus when you get a chance, please lmk if there is anything else you would like me to do to make the PR merge-able? (#27 )

aareman commented 9 months ago

Following up about this @helmus I think this feature will be helpful to a lot of people.

helmus commented 9 months ago

Can you share a screen recording of how you tested this ?

aareman commented 9 months ago

Thank you for your response.

I would prefer not to, since I work in healthcare and don't want to leak any sensitive or proprietary information about our operations.

I downloaded and built my fork and then I loaded it as an unpacked extension and that is what I am running in my screenshot.

If a recording is an absolute requirement I can setup a contrived example when I am at a computer next.

On Mon, Dec 18, 2023, 3:51 PM helmus @.***> wrote:

Can you share a screen recording of how you tested this ?

— Reply to this email directly, view it on GitHub https://github.com/helmus/Jira-Hot-Linker/issues/26#issuecomment-1861608192, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQDVV5OUVTJWEXXJYRPLO3YKCUEFAVCNFSM6AAAAAA2YRI5E2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRRGYYDQMJZGI . You are receiving this because you commented.Message ID: @.***>

helmus commented 9 months ago

Can you try testing with a public jira instance like: https://issues.apache.org/jira/projects/HIVE/issues/HIVE-26111?filter=allopenissues

aareman commented 9 months ago

jira_hotlinker.webm Here is a video

helmus commented 9 months ago

Great! , can you show it in white as well so we can confirm the current behavior still works.

aareman commented 9 months ago

image

aareman commented 9 months ago

Here is a video of both in action

https://github.com/helmus/Jira-Hot-Linker/assets/10500823/e813fe0b-4caa-40c2-9b0c-2b76823f00f6

helmus commented 9 months ago

Will release this later this week after I find the time to upgrade to the new manifest https://developer.chrome.com/docs/extensions/develop/migrate