Insonsistent CPU temperature reading behaviour

[android-808]

I've managed to get it to read the CPU temperature correctly but only if I remove --cpu=2 on default style. When specifying cpu=2 the temperature reading cuts of the unit digit e.g. 28 becomes 2, 18 becomes 1 etc.

I was specifying this as the Atom N270 features Hyperthreading. CPU load on both threads can be different which was why I was using it. It only prints the temperature on CPU 1 in this scenario but thats fine as it really is only one CPU.

After working out that lm_sensors was working correctly, I've tracked down the issue to the CPU temp section of the conkyrc. When one cpu is specified the relevant section becomes:

execi 30 sensors | grep 'Core 0' | cut -c16-17

When two cpus are specified it becomes cut -c15-16, threfore cutting off the second digit.

Looking into the source there appears to be a lot of inconsistancy in the values used for each style, some 16-17 or 15-17 with +/-, some 15-16 and 14-16.

[android-808]

There seems to be an intermittant problem with the temperature readings now. Every now and again the temperature disappears. Happens with --cpu=2 and without.

Posted here as opposed to a new bug as it was likely caused by the recent change. MIght be worth reverting the change and adjusting the cut params.

[helmuthdu]

I think we gonna wait until monday because i'm not with a linux computer in this weekend...

[android-808]

I've never delved into sed but I read '.' on its own has some special meaning like match one character. I'm wondering if it disappears only when temperature is a multiple of 10. After some experimenting, I tried escaping the '.' in your last sed command and it seems to be working ok. I've also updated my patch so that it applies the same processing on all other modes.

diff -u src/conkyrc_cairo.c mysrc/conkyrc_cairo.c --- conky_colors.orig/src/conkyrc_cairo.c 2012-03-23 15:03:30.000000000 +0000 +++ conky_colors/src/conkyrc_cairo.c 2012-03-25 17:49:35.421068454 +0100 @@ -195,18 +195,18 @@ fprintf(fp,"${goto 100}${font Ubuntu:style=Bold:size=8}${color2}${freq_g}${color} GHZ${font}\n"); fprintf(fp,"${goto 100}CPU: ${font Ubuntu:style=Bold:size=8}${color1}${cpu cpu0}%%${color}${font}\n"); if (unit == True)

• fprintf(fp,"${goto 100}Tmp: ${font Ubuntu:style=Bold:size=8}${color1}${execi 30 sensors -f | grep 'Core 0' | cut -c15-17}°F${color}${font}\n");
• fprintf(fp,"${goto 100}Tmp: ${font Ubuntu:style=Bold:size=8}${color1}${execi 30 sensors -f | grep 'Core 0' | awk '{print $3}' | sed 's/+//' | sed 's/.0//g'}${color}${font}\n"); else
• fprintf(fp,"${goto 100}Temp: ${font Ubuntu:style=Bold:size=8}${color1}${execi 30 sensors | grep 'Core 0' | cut -c16-17}°C${color}${font}\n");
• fprintf(fp,"${goto 100}Temp: ${font Ubuntu:style=Bold:size=8}${color1}${execi 30 sensors | grep 'Core 0' | awk '{print $3}' | sed 's/+//' | sed 's/.0//g'}${color}${font}\n"); } else { if (cpu == 1) { fprintf(fp,"${goto 100}${font Ubuntu:style=Bold:size=8}${color2}${freq_g}${color} GHZ${font}\n"); fprintf(fp,"${goto 100}CPU1: ${font Ubuntu:style=Bold:size=8}${color1}${cpu cpu1}%%${color}${font}\n"); if (unit == True)
• fprintf(fp,"${goto 100}Tmp: ${font Ubuntu:style=Bold:size=8}${color1}${execi 30 sensors -f | grep 'Core 0' | cut -c15-17}°F${color}${font}\n");
• fprintf(fp,"${goto 100}Tmp: ${font Ubuntu:style=Bold:size=8}${color1}${execi 30 sensors -f | grep 'Core 0' | awk '{print $3}' | sed 's/+//' | sed 's/.0//g'}${color}${font}\n"); else
• fprintf(fp,"${goto 100}Temp: ${font Ubuntu:style=Bold:size=8}${color1}${execi 30 sensors | grep 'Core 0' | cut -c16-17}°C${color}${font}\n");
• fprintf(fp,"${goto 100}Temp: ${font Ubuntu:style=Bold:size=8}${color1}${execi 30 sensors | grep 'Core 0' | awk '{print $3}' | sed 's/+//' | sed 's/.0//g'}${color}${font}\n"); } // More then 1 cpu else { @@ -214,9 +214,9 @@ fprintf(fp,"${goto 100}${font Ubuntu:style=Bold:size=8}${color2}${freq_g %d}${color} GHZ${font}\n", i); fprintf(fp,"${goto 100}CPU%d: ${font Ubuntu:style=Bold:size=8}${color1}${cpu cpu%d}%%${color}${font}\n", i, i); if (unit == True)
• fprintf(fp,"${goto 100}Tmp: ${font Ubuntu:style=Bold:size=8}${color1}${execi 30 sensors -f | grep 'Core %d' | cut -c15-17}°F${color}${font}\n", i-1);
• fprintf(fp,"${goto 100}Tmp: ${font Ubuntu:style=Bold:size=8}${color1}${execi 30 sensors -f | grep 'Core %d' | awk '{print $3}' | sed 's/+//' | sed 's/.0//g'}${color}${font}\n", i-1); else
• fprintf(fp,"${goto 100}Temp: ${font Ubuntu:style=Bold:size=8}${color1}${execi 30 sensors | grep 'Core %d' | cut -c16-17}°C${color}${font}\n", i-1);
• fprintf(fp,"${goto 100}Temp: ${font Ubuntu:style=Bold:size=8}${color1}${execi 30 sensors | grep 'Core %d' | awk '{print $3}' | sed 's/+//' | sed 's/.0//g'}${color}${font}\n", i-1); if ( i < cpu) fprintf(fp,"${voffset 15}\n"); } diff -u src/conkyrc_default.c mysrc/conkyrc_default.c --- conky_colors.orig/src/conkyrc_default.c 2012-03-23 14:08:16.000000000 +0000 +++ src/conkyrc_default.c 2012-03-24 13:43:29.000000000 +0000 @@ -173,9 +173,9 @@ fprintf(fp,"${offset 2}${color0}${font Poky:size=16}P${color}${font}${voffset -4}"); if (cputemp == True) { if (unit == True)
• fprintf(fp,"${goto %d}CPU: ${font Ubuntu:style=Bold:size=8}${color1}${cpu cpu1}%%${font} ${alignr}${font Ubuntu:style=Bold:size=8}${color1}${execi 30 sensors -f | grep 'Core 0' | awk '{print $3}' | sed 's/+//' | sed 's/.0//g'}${color}${font} ${color2}${cpugraph cpu1 8,50 %s}${color}\n", go2, color4);
• fprintf(fp,"${goto %d}CPU: ${font Ubuntu:style=Bold:size=8}${color1}${cpu cpu1}%%${font} ${alignr}${font Ubuntu:style=Bold:size=8}${color1}${execi 30 sensors -f | grep 'Core 0' | awk '{print $3}' | sed 's/+//' | sed 's/.0//g'}${color}${font} ${color2}${cpugraph cpu1 8,50 %s}${color}\n", go2, color4); else
• fprintf(fp,"${goto %d}CPU: ${font Ubuntu:style=Bold:size=8}${color1}${cpu cpu1}%%${font} ${alignr}${font Ubuntu:style=Bold:size=8}${color1}${execi 30 sensors | grep 'Core 0' | awk '{print $3}' | sed 's/+//' | sed 's/.0//g'}${color}${font} ${color2}${cpugraph cpu1 8,50 %s}${color}\n", go2, color4);
• fprintf(fp,"${goto %d}CPU: ${font Ubuntu:style=Bold:size=8}${color1}${cpu cpu1}%%${font} ${alignr}${font Ubuntu:style=Bold:size=8}${color1}${execi 30 sensors | grep 'Core 0' | awk '{print $3}' | sed 's/+//' | sed 's/.0//g'}${color}${font} ${color2}${cpugraph cpu1 8,50 %s}${color}\n", go2, color4); } else fprintf(fp,"${goto %d}CPU: ${font Ubuntu:style=Bold:size=8}${color1}${cpu cpu1}%%${color}${font} ${alignr}${color2}${cpugraph cpu1 8,60 %s}${color}\n", go2, color4); @@ -185,9 +185,9 @@ for (i = 1; i <= cpu; i++) { if (cputemp == True) { if (unit == True)
• fprintf(fp,"${goto %d}CPU%d: ${font Ubuntu:style=Bold:size=8}${color1}${cpu cpu%d}%%${font} ${alignr}${font Ubuntu:style=Bold:size=8}${color1}${execi 30 sensors -f | grep 'Core %d' | awk '{print $3}' | sed 's/+//' | sed 's/.0//g'}${color}${font} ${color2}${cpugraph cpu%d 8,50 %s}${color}\n", go2, i, i, i-1, i, color4);
• fprintf(fp,"${goto %d}CPU%d: ${font Ubuntu:style=Bold:size=8}${color1}${cpu cpu%d}%%${font} ${alignr}${font Ubuntu:style=Bold:size=8}${color1}${execi 30 sensors -f | grep 'Core %d' | awk '{print $3}' | sed 's/+//' | sed 's/.0//g'}${color}${font} ${color2}${cpugraph cpu%d 8,50 %s}${color}\n", go2, i, i, i-1, i, color4); else
• fprintf(fp,"${goto %d}CPU%d: ${font Ubuntu:style=Bold:size=8}${color1}${cpu cpu%d}%%${font} ${alignr}${font Ubuntu:style=Bold:size=8}${color1}${execi 30 sensors | grep 'Core %d' | awk '{print $3}' | sed 's/+//' | sed 's/.0//g'}${color}${font} ${color2}${cpugraph cpu%d 8,50 %s}${color}\n", go2, i, i, i-1, i, color4);
• fprintf(fp,"${goto %d}CPU%d: ${font Ubuntu:style=Bold:size=8}${color1}${cpu cpu%d}%%${font} ${alignr}${font Ubuntu:style=Bold:size=8}${color1}${execi 30 sensors | grep 'Core %d' | awk '{print $3}' | sed 's/+//' | sed 's/.0//g'}${color}${font} ${color2}${cpugraph cpu%d 8,50 %s}${color}\n", go2, i, i, i-1, i, color4); } else fprintf(fp,"${goto %d}CPU%d: ${font Ubuntu:style=Bold:size=8}${color1}${cpu cpu%d}%%${color}${font} ${alignr}${color2}${cpugraph cpu%d 8,60 %s}${color}\n", go2, i, i, i, color4); diff -u src/conkyrc_ring.c mysrc/conkyrc_ring.c --- conky_colors.orig/src/conkyrc_ring.c 2012-03-23 15:03:30.000000000 +0000 +++ conky_colors/src/conkyrc_ring.c 2012-03-25 17:52:22.798591741 +0100 @@ -157,9 +157,9 @@ fprintf(fp,"${goto 100}${font Ubuntu:style=Bold:size=8}${color2}${freq_g}${color} GHZ${font}\n"); fprintf(fp,"${goto 100}CPU1: ${font Ubuntu:style=Bold:size=8}${color1}${cpu cpu1}%%${color}${font}\n"); if (unit == True)
• fprintf(fp,"${goto 100}Tmp: ${font Ubuntu:style=Bold:size=8}${color1}${execi 30 sensors -f | grep 'Core 0' | cut -c14-16}°F${color}${font}\n");
• fprintf(fp,"${goto 100}Tmp: ${font Ubuntu:style=Bold:size=8}${color1}${execi 30 sensors -f | grep 'Core 0' | awk '{print $3}' | sed 's/+//' | sed 's/.0//g'}${color}${font}\n"); else
• fprintf(fp,"${goto 100}Temp: ${font Ubuntu:style=Bold:size=8}${color1}${execi 30 sensors | grep 'Core 0' | cut -c15-16}°C${color}${font}\n");
• fprintf(fp,"${goto 100}Temp: ${font Ubuntu:style=Bold:size=8}${color1}${execi 30 sensors | grep 'Core 0' | awk '{print $3}' | sed 's/+//' | sed 's/.0//g'}${color}${font}\n"); } // More then 1 cpu else

[helmuthdu]

Thx for the patch :) I think theres a way to summit the patch ready to include it instead of plain text... need to check how to do it.