dhedberg commented 3 years ago

18 seems to be stuck at the moment, so this is a smaller pull request that (almost) only updates Guzzle.

Notes:

Guzzle 7 requires PHP 7.2.5, so I just set that to be the requirement for this library as well
I also updated to PHPUnit 8 (PHPUnit 9 requires PHP 7.3+)
I added some more language level type hints supported in newer PHP versions

I was unable to run testCreateRefund both before and after my changes, the API returns a 500. I don't know if it's a temporary problem with the simulated API or if the test needs to be fixed.

helmutschneider commented 3 years ago

Nice, focused effort. If you are interested I could give you collaboration access so you can fix the failing test directly upstream. I don't have much time to maintain this repo these days.

dhedberg commented 3 years ago

Thanks. Apparently the test breaks because the "message" field is missing in the refund request. It's optional according to the documentation, so I guess it's a bug on their end. I added a message field to the test so it passes again. I can try reporting it too.

If you need someone to help you keep an eye out for (and fix any) bugs that pulling this might introduce, I wouldn't mind (at least attempt to) helping out with the maintenance.

helmutschneider / swish-php

Update to Guzzle 7 #19

18 seems to be stuck at the moment, so this is a smaller pull request that (almost) only updates Guzzle.