helospark / SparkBuilderGenerator

Eclipse plugin to generate builders
MIT License
38 stars 12 forks source link

Eclipse Marketplace Download URL returns 404 #16

Closed scoth closed 7 years ago

scoth commented 7 years ago

The eclipse market place has the spark builder generator listed as a plugin to install. However when it tries to download the plugin the following URL returns a 404:

https://helospark.com/eclipse_plugin/SparkBuilderGeneratorPlugin/content.xml

Is it possible to bring up this plugin on the server again, and/or provide a different means to download the plugin. ( Could you host it on github? ). I suppose I could build it myself, but I am not that familiar with building eclipse plugins.

Apologies if this is type of issue is inappropriate, I am not aware of another means of contacting the plugin maintainer.

helospark commented 7 years ago

Hi Scoth,

The generated update site contains jar for the context file and it is still available: https://helospark.com/eclipse_plugin/SparkBuilderGeneratorPlugin/content.jar

In the logs I cannot see many queries for context.xml, as far as I know Eclipse tries context.xml if it cannot find content.jar.

I guess I can unzip the jar content and make XMLs available too, but it shouldn't be necessary. Which Eclipse version do you use? Also it is possible to download via (old) FTP if HTTPS is not available for any reason, just go to help->Install new software and copy this URI: ftp://helospark.com/eclipse_plugin/SparkBuilderGeneratorPlugin/

scoth commented 7 years ago

I am using the new Oxygen (4.7) version of Eclipse. I tried the ftp url and I get the following:

An error occurred during the org.eclipse.equinox.internal.p2.engine.phases.CheckTrust phase. session context was:(profile=epp.package.jee, phase=org.eclipse.equinox.internal.p2.engine.phases.CheckTrust, operand=, action=). Error reading signed content. Exception in opening zip file: /home/shale/opt/eclipse-jee-oxygen-R-linux-gtk-x86_64/plugins/com.helospark.SparkBuilderGenerator_0.0.10.201704081131.jar

jar tfv /home/shale/opt/eclipse-jee-oxygen-R-linux-gtk-x86_64/plugins/com.helospark.SparkBuilderGenerator_0.0.10.201704081131.jar java.util.zip.ZipException: error in opening zip file at java.util.zip.ZipFile.open(Native Method) at java.util.zip.ZipFile.(ZipFile.java:219) at java.util.zip.ZipFile.(ZipFile.java:149) at java.util.zip.ZipFile.(ZipFile.java:120) at sun.tools.jar.Main.list(Main.java:1115) at sun.tools.jar.Main.run(Main.java:293) at sun.tools.jar.Main.main(Main.java:1288)

ls -ahlS /home/shale/opt/eclipse-jee-oxygen-R-linux-gtk-x86_64/plugins/com.helospark.SparkBuilderGenerator_0.0.10.201704081131.jar -rw-rw-r-- 1 shale shale 192K Jun 30 11:05 /home/shale/opt/eclipse-jee-oxygen-R-linux-gtk-x86_64/plugins/com.helospark.SparkBuilderGenerator_0.0.10.201704081131.jar

helospark commented 7 years ago

Very unusual. Based on some Google search it seems like a common problem, caused by the jar file somehow (?) gets corrupted: https://stackoverflow.com/questions/25094583/error-when-try-install-plugin Seems like some manual deleting of jar/xml files could solve it.

Some other thoughs:

scoth commented 7 years ago

I was able to install the unsigned eclipse decompiler from the marketplace. So unsigned content of some kind works.

When I try to open it as a zipfile I get the following error:

unzip -l /home/shale/opt/eclipse-jee-oxygen-R-linux-gtk-x86_64/plugins/com.helospark.SparkBuilderGenerator_0.0.10.201704081131.jar Archive: /home/shale/opt/eclipse-jee-oxygen-R-linux-gtk-x86_64/plugins/com.helospark.SparkBuilderGenerator_0.0.10.201704081131.jar End-of-central-directory signature not found. Either this file is not a zipfile, or it constitutes one disk of a multi-part archive. In the latter case the central directory and zipfile comment will be found on the last disk(s) of this archive. unzip: cannot find zipfile directory in one of /home/shale/opt/eclipse-jee-oxygen-R-linux-gtk-x86_64/plugins/com.helospark.SparkBuilderGenerator_0.0.10.201704081131.jar or /home/shale/opt/eclipse-jee-oxygen-R-linux-gtk-x86_64/plugins/com.helospark.SparkBuilderGenerator_0.0.10.201704081131.jar.zip, and cannot find /home/shale/opt/eclipse-jee-oxygen-R-linux-gtk-x86_64/plugins/com.helospark.SparkBuilderGenerator_0.0.10.201704081131.jar.ZIP, period.

This is the error I get from the marketplace. You pointed out that it could download the .jar. I wonder if it is trying to get the content.xml first?:

Unable to read repository at https://helospark.com/eclipse_plugin/SparkBuilderGeneratorPlugin/content.xml. sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target

helospark commented 7 years ago

Based on the exception about the marketplace download failure most likely it is caused by: http://gnuarmeclipse.github.io/blog/2016/12/02/plugins-install-issue/ I'm using certificate from Let's Encrypt which was added to the Java certificate store in version 1.8.101, but it should be able to check the validity of the certificate with older Java versions, but seems like it was blocked by a firewall. I'm not entirely sure what was blocked without analyzing the traffic.

"I wonder if it is trying to get the content.xml first?" In this case Eclipse does not do a single request to my server, but fail fast after checking the certificate and unable to verify it.

About the downloaded jar file, have you tried the suggested solution on StackOverflow? It really seems like it got corrupted.

$ md5sum com.helospark.SparkBuilderGenerator_0.0.10.201704081131.jar
a22f3ba546e0633d78f40ab15005eb6c  com.helospark.SparkBuilderGenerator_0.0.10.201704081131.jar
helospark commented 7 years ago

Hey Scoth!

Any update on this?

scoth commented 7 years ago

I was able to update my JDK just now. I was running jdk1.8.0_60, and updating to jdk1.8.0_131 allowed me to install the plugin without problems. Thanks for your help!