helpcrunch / android-sdk-demo

Public demo for HelpCrunch Android SDK
Apache License 2.0
9 stars 1 forks source link

Support downloadable font for emoji support #20

Closed Mahmoood closed 3 years ago

Mahmoood commented 3 years ago

Could you support Emojis by using downloadable fonts instead of bundled emojis? That will reduce apk size to about 10 MB.

Example of configuring emoji downloadable font

TalbotGooday commented 3 years ago

@Mahmoood Hi! Thanks for reporting! You can exclude emojis at all like this:

implementation ('com.helpcrunch:chat-sdk:3.x.x'){
    exclude group: "androidx.emoji", module: "emoji-bundled"
}
Mahmoood commented 3 years ago

Actually, I want to include emojis without bundling them inside the apk. Not excluding them.

TalbotGooday commented 3 years ago

@Mahmoood Yeah, it makes sense. We will add support for this feature soon

TalbotGooday commented 3 years ago

Added in 3.0.8-alpha.01

Mahmoood commented 3 years ago

Thanks for supporting that. I tried it but doesn't work I didn't see rendered emojis

Is there a sample code that contains emojis?

TalbotGooday commented 3 years ago

What version of the Android are you using?

P.S. Demo will be updated today

Mahmoood commented 3 years ago

I'm using Android 28

Mahmoood commented 3 years ago

btw, the source link is broken https://search.maven.org/artifact/com.helpcrunch/chat-sdk/3.0.8-alpha.02/aar It contains https://github.com/helpcrunch/sdk2-android which is 404 Maybe it should be https://github.com/helpcrunch/android-sdk-demo instead of https://github.com/helpcrunch/sdk2-android

Mahmoood commented 3 years ago

I didn't find a change in the Demo. I'm still waiting for the demo to get updated to know what should I do to make the emojis work using downloadable fonts.

Thanks

Mahmoood commented 3 years ago

Yeah, I remember something (this is the case either before you added the downloadable font feature). Users of my app are able to send emojis and the support team can see those emojis, but the support team of my app (using HelpCrunch console) can send them also, BUT the end-user won't see them.

In other words, the Android client app can't render emojis that are sent by the support team.

TalbotGooday commented 3 years ago

@Mahmoood Yes, you are right, the demo has not been updated as we found a bug in the emoji parsing and were working on fixing it. Errors with the fact that the end user does not see emoji are gone. Thank you for paying attention to this. :+1: I am also grateful for the comment regarding the source code link. You are absolutely right. We will fix it as soon as possible :)

Mahmoood commented 3 years ago

Now I used com.helpcrunch:chat-sdk:3.0.8-alpha.02 and YES it's working. Emojis are shown without any issue.

Thanks.

Is this version stable enough to include it in my next app release (production)?

TalbotGooday commented 3 years ago

Yes, this version is stable enough to be used in production. But if you have time, I advise you to wait a week until version 3.0.8 is released

Mahmoood commented 3 years ago

Thank you so much

TalbotGooday commented 3 years ago

I am grateful to you! Your ideas and attentiveness helped us a lot :+1: