search

helpdesk-z / helpdeskz-dev

HelpDeskZ is a free PHP based software which allows you to manage your site's support with a web-based support ticket system.
http://www.helpdeskz.com/
GNU General Public License v2.0
83 stars 64 forks source link

New feature + fix for php 7.3 #3

Closed drizzo0 closed 3 years ago

drizzo0 commented 3 years ago

Hi, I've fixed a fatal error on php 7.3, as you can see from the commit, it just needed to check if the function exists.. I wanted to keep the emails after the imap fetching.. so, to avoid to delete a function, I've thinked to create a new const and add the check before deleting, so if you accept my pull request, anyone can choose to keep the emails. If the emails are set to stay, the warning "System will delete all emails from the mailbox once downloaded. This is done to ensure best performance for the email handling process on web server side. If you want a backup of the emails, then we recommend to create a new mailbox where you forward all incoming mails to." will disappear. To avoid ticket duplication, if the deletion is set to false, it will avoid already seen messages during the fetch.

Have a nice day.

helpdesk-z commented 3 years ago

'intl' extension is required for that reason you had php error.

drizzo0 commented 3 years ago

I had the extension enabled.. I've already checked...