Closed zero734kr closed 3 years ago
Ah, no problem if you prefer to delete the tests/checkKorean.test.ts
file because I used it only to test if it was really working
Apologies for spamming this, my internet was having issues.
@tbnritzdoge applied edits for change requests as you requested 👍
The reason we didn't use toString
or the like it is because it is approximately 3x slower according to our testing. I will look into ways to rectify this now, perhaps if there is a way to use fromCharCode
with string encoding. Thank you for the PR!
Nevermind, looks good to me. Ready to merge once CI passes.
:tada: This PR is included in version 1.2.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Closes #10
Using Buffer#toString fixed this because it parses string to utf-8 automatically.