perf: remove spread operators and callback loops

helperdiscord / petitio

An HTTP/S library designed to be simple, fast, and type-strong.

https://helperdiscord.github.io/petitio/

MIT License

44 stars 6 forks source link

perf: remove spread operators and callback loops #12

Closed tbnritzdoge closed 3 years ago

tbnritzdoge commented 3 years ago

benchmark - https://measurethat.net/Benchmarks/ShowResult/177377

coveralls commented 3 years ago

Coverage decreased (-0.006%) to 98.627% when pulling fcd62d37ae8bf656c365c2ccdc19fb91d813956c on tbnritzdoge:chore/remove-spread-operator into bcd7ef95a9e1bc6d92578d573c2b81004efeb456 on helperdiscord:master.

coveralls commented 3 years ago

Coverage remained the same at 98.633% when pulling ec548e1ef1ea19b19cee7efc8b17915e29e98ddb on tbnritzdoge:chore/remove-spread-operator into d8344e44bb2ca247082c7f330354a76869e49793 on helperdiscord:master.

Nytelife26 commented 3 years ago

Unsure as to how this will play out with latest linting rules. Putting this on hold until docs gets merged.

Nytelife26 commented 3 years ago

Designating as draft until the docs PR is merged and we can reach 100% coverage.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: