helppages / feedback

A public repo for feedback on HelpPag.es
0 stars 0 forks source link

Main nav should be page title, not derived from filename #5

Closed matryer closed 9 years ago

matryer commented 10 years ago
mazondo commented 10 years ago

This would require me to parse it out on data loading, otherwise I'd have to pull all the pages down completely which would be huge. Right now I only pull the filepath to generate the menu and then I load the page body when someone clicks on the link.

matryer commented 10 years ago

How is the nav stored?

On Jan 23, 2014, at 2:05 AM, Ryan notifications@github.com wrote:

This would require me to parse it out on data loading, otherwise I'd have to pull all the pages down completely which would be huge. Right now I only pull the filepath to generate the menu and then I load the page body when someone clicks on the link.

— Reply to this email directly or view it on GitHub.

mazondo commented 10 years ago

There is no nav, really, that's why the markup for it gets so deep. I have an array of file paths to work with, and I generate the nav from there. It needs to be pre-rendered and dropped on the page, really. But either way, no access to the page content until they load the page.

matryer commented 10 years ago

You could improve this:

This would be nice because you could actually provide other features later too. Like only show this item if debug=true or something.

On Jan 23, 2014, at 11:19 AM, Ryan notifications@github.com wrote:

There is no nav, really, that's why the markup for it gets so deep. I have an array of file paths to work with, and I generate the nav from there. It needs to be pre-rendered and dropped on the page, really. But either way, no access to the page content until they load the page.

— Reply to this email directly or view it on GitHub.

mazondo commented 9 years ago

can now edit titles on your own. Defaults to page title.