helppery-com / meetnav-frontend-base

0 stars 2 forks source link

issue fixed #3 #5

Closed shishir0019 closed 3 years ago

shishir0019 commented 3 years ago

Checkout this

gbrian commented 3 years ago

So far so good @shishir0019, just small things:

setTimeout(() => {
  foo().then(() => bar())
}, 1000)

Please use

setTimeout(async () => {
  await foo()
  bar()
}, 1000)

Or surround with try/catch when needed

setTimeout(async () => {
  try {
    await foo()
    bar()
  } catch (ex) {
    // ....
 }
}, 1000)
gbrian commented 3 years ago

My bad @shishir0019 , did not explain myself (I'll be working on guidelines soon)

I expect Login and Register become a component with a Dialog I can invoke from anywhere

Page.vue

 <q-btn type="submit" :label="$t('welcomePage.signup')" class="q-mt-md nav-button" color="indigo-10" 
 @click="openDialog" />

Login.vue

<template>
    <q-dialog v-model="openRegisterDialog" persistent transition-show="scale" transition-hide="scale">
 ....

So when a user navigates to a registered users only section we can invoke Login prior to let go ahead or return to home page. Does it make sense?

Thanks