Closed shishir0019 closed 3 years ago
So far so good @shishir0019, just small things:
Can you please add message text to inform when login failed:
Can you please create a component for each dialog
under src/components folder so they can be invoked from any part of the application
Can you please use async
pattern as much as possible?
Example
setTimeout(() => {
foo().then(() => bar())
}, 1000)
Please use
setTimeout(async () => {
await foo()
bar()
}, 1000)
Or surround with try/catch when needed
setTimeout(async () => {
try {
await foo()
bar()
} catch (ex) {
// ....
}
}, 1000)
My bad @shishir0019 , did not explain myself (I'll be working on guidelines soon)
I expect Login and Register become a component with a Dialog I can invoke from anywhere
Page.vue
<q-btn type="submit" :label="$t('welcomePage.signup')" class="q-mt-md nav-button" color="indigo-10"
@click="openDialog" />
Login.vue
<template>
<q-dialog v-model="openRegisterDialog" persistent transition-show="scale" transition-hide="scale">
....
So when a user navigates to a registered users only
section we can invoke Login prior to let go ahead or return to home page. Does it make sense?
Thanks
Checkout this