Search Submission - Githubissues

helppery-com / meetnav-frontend-base

0 stars 2 forks source link

Search Submission #9

Closed shahabgohar closed 3 years ago

shahabgohar commented 3 years ago

Search Page added. dummy action method in action.js in search directory is wriiten for fetching data. I have read the issue regarding best practices and will be implemented after this pull request There is also refactoring done in the previous task. Thank you !

gbrian commented 3 years ago

@shahabgohar , can you check those conflicts, everything else is fine! 👍

shahabgohar commented 3 years ago

@gbrian conflicts ressolved

gbrian commented 3 years ago

Fix responsive (screenshot is from a MacBook (witdh 1425px)

Footer should not be on top of results but at the end, so don't use for this page

Mobile resulsts page:

please make that headers "dense":

Change user icon by a "burger" icon add user entre and navigation tabs there
recuce search input to fit between logo anf user icon

Sorry, didn't see this things beore.

shahabgohar commented 3 years ago

@gbrian duly noted

shahabgohar commented 3 years ago

@gbrian review changes Screenshot_20210216-135631_Chrome

Screenshot_20210216-135638_Chrome

gbrian commented 3 years ago

Great work @shahabgohar ! 👏