Fixed a regression where single embedded entities would cause errors

helpscout / helpscout-api-php

PHP Wrapper for the Help Scout API

MIT License

98 stars 62 forks source link

Fixed a regression where single embedded entities would cause errors #188

Closed bkuhl closed 5 years ago

bkuhl commented 5 years ago

This PR re-implements the solution for the errors described in https://github.com/helpscout/helpscout-api-php/issues/187. Looking through the PR/commit history I can't find any record of the test case re-added here being originally added or removed, despite it being present in https://github.com/helpscout/helpscout-api-php/pull/176/files.

bkuhl commented 5 years ago

I'm closing this out as I'd like to investigate what's going on a little deeper. The ideal solution doesn't force embeds to be collections when they aren't.