helpscout / helpscout-api-php

PHP Wrapper for the Help Scout API
MIT License
98 stars 62 forks source link

Rename ConversationFilter object methods for clarity #224

Closed anthonyterrell closed 4 years ago

anthonyterrell commented 4 years ago

Relates to #208

To reduce confusion when using a ConversationFilters object some methods have been changed. This is a breaking change targeting version 3. All usages and tests have been updated.

Changes

  1. withMailbox => inMailbox
  2. withStatus => inStatus
  3. withFolder => inFolder
  4. withTag => hasTag
  5. withTags => hasTags
  6. withAssignedTo => assignedTo
  7. withModifiedSince => modifiedSince
  8. withNumber => byNumber
  9. withSortField => sortField
  10. withSortOrder => sortOrder