Rename CustomerFilter object methods for clarity - Githubissues

helpscout / helpscout-api-php

PHP Wrapper for the Help Scout API

MIT License

98 stars 62 forks source link

Rename CustomerFilter object methods for clarity #226

Closed anthonyterrell closed 4 years ago

anthonyterrell commented 4 years ago

Relates to #208

To reduce confusion when using a CustomerFilter object some methods have been changed. This is a breaking change targeting version 3. All usages and tests have been updated.

Changes

withFirstName => byFirstName
withLastName => byLastName
withMailbox => inMailbox
withModifiedSince => modifiedSince
withSortField => sortField
withSortOrder => sortOrder

~To be merged in after #224~