search

helpscout / helpscout-api-php

PHP Wrapper for the Help Scout API
MIT License
98 stars 62 forks source link

add sort options to ConversationFilter #260

Closed amybowers closed 3 years ago

amybowers commented 3 years ago

Current behavior Trying to use the sortField 'waitingSince' or 'customerName' returns an error even though they're allowed by the API.

Expected behavior Should be able to sort by these fields.

Steps to reproduce

  1. create a filter $filters = (new ConversationFilters())->sortField('waitingSince');

  2. try to retrieve conversations using that filter You will get an error

    Expected one of: "createdAt", "customerEmail", "mailboxid", "modifiedAt", "number", "score", "status", "subject". Got: "waitingSince"

bkuhl commented 3 years ago

Thanks for reporting this, we've just released v3.3.0 with your contribution!