search

helpscout / helpscout-api-php

PHP Wrapper for the Help Scout API
MIT License
98 stars 62 forks source link

Support PHP 8 #263

Closed miken32 closed 3 years ago

miken32 commented 3 years ago

Thank you!

$  php -v
PHP 8.0.0 (cli) (built: Dec 10 2020 01:42:25) ( NTS )
Copyright (c) The PHP Group
Zend Engine v4.0.0-dev, Copyright (c) Zend Technologies
    with Xdebug v3.0.1, Copyright (c) 2002-2020, by Derick Rethans

$ vendor/bin/phpunit
PHPUnit 8.5.14 by Sebastian Bergmann and contributors.

Error:         This version of PHPUnit does not support code coverage on PHP 8

...............................................................  63 / 516 ( 12%)
............................................................... 126 / 516 ( 24%)
............................................................... 189 / 516 ( 36%)
............................................................... 252 / 516 ( 48%)
............................................................... 315 / 516 ( 61%)
............................................................... 378 / 516 ( 73%)
............................................................... 441 / 516 ( 85%)
............................................................... 504 / 516 ( 97%)
............                                                    516 / 516 (100%)

Time: 641 ms, Memory: 22.00 MB
bkuhl commented 3 years ago

Thanks for submitting this. It's failing as a result of some coding standards issues that haven't yet been taken care of in this repo. I've started a PR to fix these and will merge this one once we can get master passing and this branch updated.

bkuhl commented 3 years ago

@miken32 Would you mind pulling in the latest master to resolve the failures?

miken32 commented 3 years ago

Looks like that did it.